search

cnoe-io / backstage-app

7 stars 15 forks source link

Fix for k8s-apply plugin config issue #31

Closed mmaroth closed 2 weeks ago

nimakaviani commented 3 weeks ago

thanks Mani for this. can you provide some details as to what the problem is and what is this change fixing?

Also can you sign the DCO with a -s flag when you commit your changes?

nimakaviani commented 3 weeks ago

also looks like what you want to delete, comes from the k8s-config.yaml file here, right? https://github.com/cnoe-io/stacks/blob/main/ref-implementation/backstage/manifests/install.yaml#L199-L203

if thats the case, and if deleting is the option, then the correct key would be skipTLSVerify.

cross checking wiht @nabuskey here.

mmaroth commented 3 weeks ago

When we set skipTLSVerify as "True", we dont have to include CA Data in the kubeconfig file but the plugin is including CAData in plain text format instead of base64 encode, which is causing kubectl auth issue. So I have added condition to remove it if "skipTLSVerify" set to true.

nabuskey commented 3 weeks ago

Can you add steps and configurations to reproduce the issue you are having? I thought I understood what you were trying to do but I am confused after reading this PR.

mmaroth commented 3 weeks ago

I have made change as per your comments @nabuskey