cnoe-io / backstage-app

7 stars 15 forks source link

spark plugin appears to need backstage-commons 0.19.0 #7

Closed nimakaviani closed 1 year ago

nimakaviani commented 1 year ago

Had to update backends-common for the spark plugin to start successfully. Otherwise I would receive the following error:

❯ yarn start-backend
yarn run v1.22.19
$ yarn workspace backend start
$ backstage-cli package start
Build succeeded
/Users/nkaviani/workspaces/git/cnoe/backstage-app/packages/backend/dist/main.js:411
/******/                        throw e;
                                ^

TypeError: Cannot read properties of undefined (reading 'redacter')
    at Object.<anonymous> (/Users/nkaviani/workspaces/git/cnoe/backstage-app/node_modules/@backstage/backend-common/dist/index.cjs.js:110:46)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at Module.require (node:internal/modules/cjs/loader:1141:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Users/nkaviani/workspaces/git/cnoe/backstage-app/node_modules/@backstage/backend-app-api/dist/index.cjs.js:24:21)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)

Also, had to bump the front-end and backend kubernetes plugins and make tweaks to the code for the spark changes to remain compatible.

nabuskey commented 1 year ago

I've updated versions from the other branch. This isn't necessary now.