search

cnoe-io / idpbuilder

Spin up a complete internal developer platform with only Docker required as a dependency.
https://cloud-native.slack.com/archives/C05TN9WFN5S
Apache License 2.0
191 stars 59 forks source link

Rename the `-p` flag? #264

Open nabuskey opened 5 months ago

nabuskey commented 5 months ago

Do we want to rename the --package-dir flag? Right now, it expects a directory that contain ArgoCD application files but this behaviour will likely change soonish. If that happens, we should consider changing this flag's name.

We should ensure that --package-dir flag works going forward for backward compatibility purposes though.

cmoulliard commented 5 months ago

Do we want to rename the --package-dir flag?

I'm in favor to rename it in order to been able to create an IDP cluster using packages coming from different locations. Of course, that will imply that we prefix each package with a URI even if we will upload the package resources using a folder/dir 

--package files:///a/b/c
--package https://
--package ssh://
--package git://
--package ftp:///
nimakaviani commented 5 months ago

yeah should be an easy lift to add the new flag as an alternative and plan to deprecate this in a v0.6 release.