search

cnoe-io / idpbuilder

Spin up a complete internal developer platform with only Docker required as a dependency.
https://cloud-native.slack.com/archives/C05TN9WFN5S
Apache License 2.0
152 stars 45 forks source link

Improve the install.sh script and remove sudo #273

Open cmoulliard opened 1 month ago

cmoulliard commented 1 month ago

TODO

Improve the install.sh script as it asks a sudo password on MacOS machine while that should not not be required.

curl -fsSL https://raw.githubusercontent.com/cnoe-io/idpbuilder/main/hack/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 26.1M  100 26.1M    0     0  8659k      0  0:00:03  0:00:03 --:--:-- 11.0M
idpbuilder 0.4.1 go1.21.5 darwin/arm64
Password:
sudo: a password is required

See : https://docs.brew.sh/FAQ#why-does-homebrew-say-sudo-is-bad

nabuskey commented 1 month ago

Oh yeah it shouldn't use sudo. We need to fix it.

nimakaviani commented 1 month ago

I feel like we should get rid of this script and rely on #271 for installation of the binaries. I will find some time to do some final testing of that PR in an organization and then we can merge it.

271 is pending right now because my tests were with a git user account and not an org setup.