search

cnoe-io / idpbuilder

Spin up a complete internal developer platform with only Docker required as a dependency.
https://cloud-native.slack.com/archives/C05TN9WFN5S
Apache License 2.0
149 stars 45 forks source link

Fixing URL issues in ReadMe #319

Closed elamaran11 closed 1 week ago

elamaran11 commented 1 week ago

This PR is to fix incorrect URL in ReadMe for gitea and argocd repo.

cmoulliard commented 1 week ago

The ingress addresses to access: gitea and argocd are respectively:

[snowdrop@charles-vm ~]$ k get ingress -A
NAMESPACE   NAME                     CLASS   HOSTS                                 ADDRESS     PORTS   AGE
argocd      argocd-server-ingress    nginx   argocd.cnoe.localtest.me              localhost   80      4h31m
gitea       my-gitea                 nginx   gitea.cnoe.localtest.me               localhost   80      4h31m

So I don t really understand why you are changing them into: cnoe.localtest.me:8443/gitea/... and cnoe.localtest.me:8443/argocd/...

elamaran11 commented 1 week ago

The ingress addresses to access: gitea and argocd are respectively:

[snowdrop@charles-vm ~]$ k get ingress -A
NAMESPACE   NAME                     CLASS   HOSTS                                 ADDRESS     PORTS   AGE
argocd      argocd-server-ingress    nginx   argocd.cnoe.localtest.me              localhost   80      4h31m
gitea       my-gitea                 nginx   gitea.cnoe.localtest.me               localhost   80      4h31m

So I don t really understand why you are changing them into: cnoe.localtest.me:8443/gitea/... and cnoe.localtest.me:8443/argocd/...

We are not changing the Ingress but the URL isnt correct.

cmoulliard commented 1 week ago

We are not changing the Ingress but the URL isnt correct.

The URLs to be used are:

https://gitea.cnoe.localtest.me:8443/
https://argocd.cnoe.localtest.me:8443
elamaran11 commented 1 week ago

We are not changing the Ingress but the URL isnt correct.

The URLs to be used are:

https://gitea.cnoe.localtest.me:8443/
https://argocd.cnoe.localtest.me:8443

The URLs that work for me with latest version and setup are :

https://cnoe.localtest.me:8443/argocd
https://cnoe.localtest.me:8443/gitea
nabuskey commented 1 week ago

@cmoulliard is correct. What you are suggesting is for path based routing only and does not apply for all cases. See https://github.com/cnoe-io/idpbuilder/pull/267