add support for helm object

cnoe-io / idpbuilder

Spin up a complete internal developer platform with only Docker required as a dependency.

https://cloud-native.slack.com/archives/C05TN9WFN5S

Apache License 2.0

174 stars 56 forks source link

add support for helm object #340

Closed nabuskey closed 2 months ago

nabuskey commented 2 months ago

fixes: #339

With this PR we now look at the helmValueObject field in ArgoCD applications.

I ended up implementing a general replacement function that could be used for any field in ArgoCD application spec to replace cnoe:// with derived git URL. This functionality is not enabled in this PR however. I am not sure if this is something we want to support.

csantanapr commented 2 months ago

Thanks @nabuskey I think this fix the issue I posted.

I'm ok not having the functionality to replace everywhere for now. Maybe we can wait to see if someone asks for it, and even then we can put behind a experimental env variable to allow it.