search

cnoe-io / idpbuilder

Spin up a complete internal developer platform with only Docker required as a dependency.
https://cloud-native.slack.com/archives/C05TN9WFN5S
Apache License 2.0
200 stars 59 forks source link

fix gitea registry for path based routing #411

Closed nabuskey closed 1 month ago

nabuskey commented 1 month ago

fixes: #410 fixes: #344

nabuskey commented 1 month ago

The name of the parameter that we are using here: use-path-routing is not meaningful as in fact it allows the user to configure the internal container registry using either the FQDN of gitea or the domain name.

I suggest to rename it to something like no-fqdn

By the way, the documentation should be reviewed to detail what idp do when this parameter/Argument is selected !!

We can revisit the flag name in the future for sure. We do need to illustrate what the flag does too.

nabuskey commented 1 month ago

Opened https://github.com/cnoe-io/idpbuilder/issues/416 to track what Blake said.