search

cnp3 / ipmininet

Mininet extension to make experimenting with IP networks easy
GNU General Public License v2.0
65 stars 51 forks source link

Add support for FRR vtysh #110

Closed gromit1811 closed 3 years ago

gromit1811 commented 3 years ago

vtysh in FRR by default uses Unix domain sockets in /var/run/frr to access the CLI of routing daemons. So far, running vtysh always caused it to connect to the most recently started FRR daemons because they created their sockets last and thus overwrote those of earlier daemons. This commit makes /var/run/frr a private directory specific to each router, so running vtysh in the router's namespace makes it connect to the daemons responsible for that router.

I don't know which directory was used by the pre-FRR Quagga (maybe /var/run/quagga?), but it proabably simply could be added to the list and we'd have vtysh support both for FRR and Quagga in case somebody is still using the latter.

Signed-off-by: Martin Buck mb-tmp-tvguho.pbz@gromit.dyndns.org

jadinm commented 3 years ago

Can one of the admins verify this patch?

jadinm commented 3 years ago

Thanks for the patch !

I don't know which directory was used by the pre-FRR Quagga (maybe /var/run/quagga?), but it proabably simply could be added to the list and we'd have vtysh support both for FRR and Quagga in case somebody is still using the latter.

We don't support Quagga, only FRR. So, your PR looks good to me :+1:

jadinm commented 3 years ago

Jenkins, run tests