search

cnp3 / ipmininet

Mininet extension to make experimenting with IP networks easy
GNU General Public License v2.0
65 stars 51 forks source link

[mininet vm] Checkout mininet with release tag #82

Closed butjar closed 4 years ago

butjar commented 4 years ago

The mininet release of the vm build script is pinned to a certain tag. At the moment, this tag is only used for the download of the 'install-mininet-vm.sh' script. To chekcout mininet with the same tag, the option has to be passed to the script. See: https://github.com/mininet/mininet/blob/master/util/vm/install-mininet-vm.sh#L40

Pass the release tag to the mininet vm script.

butjar commented 4 years ago

I guess this was the intended behavior when the mininet release version was pinned.

Output from my VM when running build_vm.sh from this branch:

...
    terranet-base: Reading state information...
    terranet-base: git is already the newest version (1:2.17.1-1ubuntu0.7).
    terranet-base: openssh-server is already the newest version (1:7.6p1-4ubuntu0.3).
    terranet-base: 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    terranet-base: Cloning into 'mininet'...
    terranet-base: ~/mininet ~ /usr/local/src
    terranet-base: Note: checking out '2.3.0d6'.
    terranet-base:
    terranet-base: You are in 'detached HEAD' state. You can look around, make experimental
    terranet-base: changes and commit them, and you can discard any commits you make in this
    terranet-base: state without impacting any branches by performing another checkout.
    terranet-base:
    terranet-base: If you want to create a new branch to retain commits you create, you may
    terranet-base: do so (now or later) by using -b with the checkout command again. Example:
    terranet-base:
    terranet-base:   git checkout -b <new-branch-name>
    terranet-base:
    terranet-base: HEAD is now at e043664 2.3.0d6
...
jadinm commented 4 years ago

I guess this was the intended behavior when the mininet release version was pinned.

Yes indeed, thanks :+1: