search

cnpm / cnpmcore

Private NPM Registry for Enterprise
https://npmmirror.com
MIT License
622 stars 84 forks source link

fix: incorrect latest tag in strict specific version #610

Closed hezhengxu2018 closed 11 months ago

hezhengxu2018 commented 1 year ago
  1. 添加新建任务时的重复版本校验，去除执行任务时的版本去重
  2. 在strictSyncSpecificVersion开启时，修改为从可用版本中选择latestTag。之前从任务的指定版本中生成latestTag逻辑不正确
codecov[bot] commented 1 year ago

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (6624a36) 97.45% compared to head (bac284f) 96.83%. Report is 139 commits behind head on master.

Files Patch % Lines
config/config.default.ts 53.03% 31 Missing :warning:
.../port/controller/admin/PaddingVersionController.ts 48.83% 22 Missing :warning:
app/core/service/FixNoPaddingVersionService.ts 54.54% 15 Missing :warning:
app/core/service/PackageSearchService.ts 93.64% 15 Missing :warning:
app/core/service/PackageSyncerService.ts 85.84% 15 Missing :warning:
app/port/schedule/SyncBinaryWorker.ts 21.42% 11 Missing :warning:
app/repository/PackageVersionRepository.ts 87.95% 10 Missing :warning:
app/core/service/PackageVersionFileService.ts 91.48% 8 Missing :warning:
app/core/entity/PaddingSemVer.ts 88.00% 6 Missing :warning:
app/core/service/PackageVersionService.ts 94.91% 6 Missing :warning:
... and 11 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #610 +/- ## ========================================== - Coverage 97.45% 96.83% -0.62% ========================================== Files 168 180 +12 Lines 15691 17548 +1857 Branches 2018 2285 +267 ========================================== + Hits 15291 16993 +1702 - Misses 400 555 +155 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fengmk2 commented 11 months ago

@hezhengxu2018 邀请你加入 cnpm core team https://github.com/orgs/cnpm/teams/core/members