UestcCarpediem commented 9 months ago

646 修复在同步过程中，revalidate 时 lodash sortby 无法正常将 18-Dec-2019 16:41 格式的date排序导致 diff 添加了非预期的 dir

fengmk2 commented 9 months ago

得加个单测确保一下

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.82%. Comparing base (64bb78c) to head (2470621). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #647 +/- ## ======================================= Coverage 96.82% 96.82% ======================================= Files 180 180 Lines 17626 17630 +4 Branches 2293 2297 +4 ======================================= + Hits 17067 17071 +4 Misses 559 559 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

UestcCarpediem commented 8 months ago

得加个单测确保一下

又调整了一下，排序放在循环体内，复杂度为n平方，有超时风险。

elrrrrrrr commented 8 months ago

@UestcCarpediem 用例修复下？ 🙏🏻

UestcCarpediem commented 8 months ago

@UestcCarpediem 用例修复下？ 🙏🏻

好的

UestcCarpediem commented 8 months ago

@UestcCarpediem 用例修复下？ 🙏🏻 Node.js CI / test-mysql57-fs-nfs (16, ubuntu-latest) 这个用例报错好像是node16的CVE导致的

cnpm / cnpmcore

fix: revalidate sort bug #647

646 修复在同步过程中，revalidate 时 lodash sortby 无法正常将 18-Dec-2019 16:41 格式的date排序导致 diff 添加了非预期的 dir

Codecov Report