fix: only set chrome-for-testing data timestamp after sync task finish

fengmk2 commented 7 months ago

closes https://github.com/cnpm/cnpmcore/issues/652

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.82%. Comparing base (ae83136) to head (0f2ffe2).

Files	Patch %	Lines
...pp/common/adapter/binary/ChromeForTestingBinary.ts	80.00%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #653 +/- ## ========================================== - Coverage 96.84% 96.82% -0.02% ========================================== Files 180 180 Lines 17598 17622 +24 Branches 2292 2293 +1 ========================================== + Hits 17043 17063 +20 - Misses 555 559 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fengmk2 commented 7 months ago

[2024-02-23T16:19:44.903Z] 🚧🚧🚧🚧🚧 Start sync binary "chrome-for-testing" 🚧🚧🚧🚧🚧
[2024-02-23T16:19:45.207Z] 🟢 log: https://r.cnpmjs.org/-/binary/chrome-for-testing/syncs/65d8c5943f3e44e8b54ca5ab/log
[2024-02-23T16:19:45.207Z] 🟢🟢🟢🟢🟢 "chrome-for-testing" 🟢🟢🟢🟢🟢

没数据

fengmk2 commented 7 months ago

https://cnpmcore.oss-cn-hongkong.aliyuncs.com/binaries/chrome-for-testing/syncs/2024/02/240128-65d8d5a203cf2c503fe409f4.log

果然是大量错误

cnpm / cnpmcore

fix: only set chrome-for-testing data timestamp after sync task finish #653

Codecov Report