search

cnpm / cnpmcore

Private NPM Registry for Enterprise
https://npmmirror.com
MIT License
573 stars 78 forks source link

feat: use mysql2@^3.9.4 #669

Closed fengmk2 closed 2 months ago

fengmk2 commented 2 months ago

closes https://github.com/cnpm/cnpmcore/issues/668

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The update in the package.json file involves upgrading the mysql2 package from version ^2.3.0 to ^3.9.4 for security reasons. Additionally, the adjustment in the workflow configuration removes Node.js version 16 from the versions tested against.

Changes

File(s) Change Summary
package.json Increased mysql2 version from ^2.3.0 to ^3.9.4.
.github/workflows/nodejs.yml Removed Node.js version 16 from the supported versions in the workflow.

Assessment against linked issues

Objective Addressed Explanation
Use mysql2 v3 for security update (#668) ✅

🐰✨ Hopping through the code, with a swift, joyful tweak, Updated a line, now the future's not bleak. Security's tight, with version three-nine, Now safer we are, with this change so fine! Cheers to the devs, with carrots to seek! 🥕 🐰✨

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 85bb948d522107daaa52deb132c1cc4c5ff8f9c1 and f8e946aa66ada78c407d61a82e8517c4670b6bed.
Files selected for processing (1) * .github/workflows/nodejs.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/nodejs.yml (1)
`35-35`: Updated Node.js versions to 18, 20, and 21, removing version 16 due to compatibility issues. Ensure that the application is fully compatible with these newer versions.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/mysql2@3.9.4 environment, network Transitive: eval +6 1.84 MB sidorares

🚮 Removed packages: npm/mysql2@2.3.3, npm/s3-cnpmcore@1.1.2, npm/semver@7.6.0, npm/ssri@8.0.1, npm/type-fest@2.19.0, npm/typescript@5.2.2, npm/ua-parser-js@1.0.37, npm/validate-npm-package-name@3.0.0

View full report↗︎

fengmk2 commented 2 months ago

/opt/hostedtoolcache/node/16.20.2/x64/bin/node: Error: Attempt to revert an unknown CVE [CVE-2023-46809]

@killagu 看起来得判断一下，在 node 16 不能 revert 了