search

cnpm / cnpmcore

Private NPM Registry for Enterprise
https://npmmirror.com
MIT License
573 stars 78 forks source link

feat: support unpkg alias path access entry file #674 #675

Closed chilingling closed 1 month ago

chilingling commented 1 month ago

closes https://github.com/cnpm/cnpmcore/issues/674

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent update enhances the PackageVersionFileController to handle compatibility with unpkg by searching for possible file entries and implementing redirection when a requested file is not found. It also includes a new package.json for a test package and additional test cases for redirecting to potential file entries.

Changes

Files Change Summary
app/port/controller/PackageVersionFileController.ts Added #searchPossibleEntries method and redirection logic.
test/fixtures/@cnpm/test-find-entry/package.json Introduced package.json with metadata for a test package.
test/port/controller/PackageVersionFileController/listFiles.test.ts Added a test case for redirecting to a possible file entry.

🐇 In the code's deep warren, changes abound,
New paths and entries, now easily found.
With tests to guide, and logic bright,
Our code hops forward, day and night.
Redirects in place, all errors take flight,
The rabbit's code, a pure delight.
🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
chilingling commented 1 month ago

我想请问下：

  1. 有没有 beta 环境之类的？我想看看在 import-map 场景下使用 unpkg 特性还会不会有什么问题
  2. 编写测试用例有指导文档吗？我加几个测试用例。

@fengmk2 @atian25

atian25 commented 1 month ago

写单测，以及本地跑 docker 就可以了？

chilingling commented 1 month ago

写单测，以及本地跑 docker 就可以了？

单测本地应该没问题，但是测试在 import-map 场景下的使用能力可能要同步太多 package 到本地，有点费劲

fengmk2 commented 1 month ago

我想请问下：

  1. 有没有 beta 环境之类的？我想看看在 import-map 场景下使用 unpkg 特性还会不会有什么问题
  2. 编写测试用例有指导文档吗？我加几个测试用例。

@fengmk2 @atian25

参考现有的单测用例写吧。

chilingling commented 1 month ago

我想请问下：

  1. 有没有 beta 环境之类的？我想看看在 import-map 场景下使用 unpkg 特性还会不会有什么问题
  2. 编写测试用例有指导文档吗？我加几个测试用例。

@fengmk2 @atian25

参考现有的单测用例写吧。

OK，这种推单测用例上来

chilingling commented 1 month ago

@atian25 @fengmk2 大佬们下午好，单元测试加了，麻烦看看这样加是不是正确的，有问题 Or review我及时改。