Closed elrrrrrrr closed 4 months ago
The recent updates to PlaywrightBinary.ts
and its corresponding test file involve modifying download paths for various platforms and browsers, including the addition of new paths for macOS 14 and adjustments for other operating systems. The test file has been updated to reflect these changes, including altering assertions and the expected number of items in the result array.
Files | Change Summary |
---|---|
app/common/adapter/binary/PlaywrightBinary.ts |
Modified download paths for chromium , chromium-tip-of-tree , firefox , firefox-beta , webkit , ffmpeg , and android . Added new paths for macOS 14. Set some Ubuntu 18.04 paths to undefined . |
test/common/adapter/binary/PlaywrightBinary.test.ts |
Updated assertions to match new item names and order in result.items array. Adjusted array length check from 8 to 7. |
🐇 Paths updated, binaries in line,
For macOS 14, new entries shine.
Ubuntu's older paths we leave behind,
In tests, new order we now find.
Code evolves, a dance so fine,
Playwright's journey, by design.
🖥️✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
mac14
andmac14-arm64
platforms for Chromium and Chromium tip-of-tree downloads.Bug Fixes
Tests