fix: rc version should match `*` version

fengmk2 commented 1 month ago

closes https://github.com/cnpm/unpkg-white-list/issues/63

Summary by CodeRabbit

Bug Fixes
- Improved package version checking to support wildcard (*) versions, ensuring better compatibility and flexibility.
- Fixed issues in handling release candidate (rc) versions in package version checks.

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates involve enhancing the PackageVersionFileService to better handle package version checks, including support for wildcard (*) versions. Additionally, a bugfix in listFiles.test.ts ensures compatibility with release candidate (rc) versions, improving the reliability and accuracy of package version validations.

Changes

Files/Groups	Change Summary
`app/core/service/PackageVersionFileService.ts`	Updated the logic for checking package versions to include wildcard (`*`) versions and improved the condition checks for package configuration.
`test/port/controller/PackageVersionFileController/listFiles.test.ts`	Implemented a bugfix to support rc versions, including setting configuration flags, creating packages with specific versions and descriptions, making HTTP requests with different versions, and asserting responses.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant PackageVersionFileController
    participant PackageVersionFileService
    participant PackageRegistry

    Client->>PackageVersionFileController: Request for package files
    PackageVersionFileController->>PackageVersionFileService: Check package version
    PackageVersionFileService->>PackageRegistry: Fetch package configuration
    PackageRegistry-->>PackageVersionFileService: Return package configuration
    PackageVersionFileService-->>PackageVersionFileController: Return version check result
    PackageVersionFileController-->>Client: Respond with package files or error

Assessment against linked issues

Objective	Addressed	Explanation
Ensure the rule for package version checking includes wildcard (`*`) support (#63)	✅
Fix the bug to support rc versions in package version checks (#63)	✅

Poem

In code we trust, with versions so grand,
Wildcards and rc, now perfectly planned.
Packages flow, like rivers so free,
Bugs fixed and tested, for all to see.
A rabbit's delight, in lines of code,
Enhancing the path, on which we all rode.
🌟🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.82%. Comparing base (96648fd) to head (7bd72a4). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #692 +/- ## ======================================= Coverage 96.82% 96.82% ======================================= Files 181 181 Lines 18014 18014 Branches 2345 2340 -5 ======================================= Hits 17442 17442 Misses 572 572 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fengmk2 commented 1 month ago

学习了 semver 的一个新知识点。

Learned a semver of new things to know.

cnpm / cnpmcore