cnpm / cnpmcore

Private NPM Registry for Enterprise
https://npmmirror.com
MIT License
607 stars 80 forks source link

fix: ignore hook when disable #702

Closed elrrrrrrr closed 2 months ago

elrrrrrrr commented 2 months ago

Currently, triggerHookWorkerMaxConcurrentTasks is 10 by defualt, which can lead to some redis queries even hookEnable is not activated.

  • ♻️ Follow CreateTriggerHookWorker, when hookEnable is not activated, do not query task queue.

目前 triggerHookWorkerMaxConcurrentTasks 默认为 10,在未开启 hookEnable 时会带来一些冗余的 redis 查询

  • ♻️ 参照 CreateTriggerHookWorker 逻辑,hookEnable 关闭时,不进行存量任务轮训

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

A conditional check has been added to the subscribe method in the TriggerHookWorker class to ensure that the hookEnable configuration parameter is set to true before executing further logic. This update is aimed at enhancing the control flow by preventing the method from proceeding when the hook functionality is disabled.

Changes

File Path Change Summary
app/port/schedule/TriggerHookWorker.ts Added a check for this.config.cnpmcore.hookEnable in subscribe method to ensure hooks are enabled before processing.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TriggerHookWorker
    participant Config

    User ->> TriggerHookWorker: subscribe()
    TriggerHookWorker ->> Config: this.config.cnpmcore.hookEnable
    alt hookEnable is true
        TriggerHookWorker ->> TriggerHookWorker: Proceed with subscription logic
    else hookEnable is false
        TriggerHookWorker ->> TriggerHookWorker: Skip subscription logic
    end

Poem

In code's vast realm, a check we weave,
Ensuring hooks are right to leave.
With logic clear and bugs held tight,
Our TriggerHookWorker shines so bright.
Enabled paths, we now construe,
For flawless runs, our goal in view.
🌟💻✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.81%. Comparing base (ca6ce4e) to head (0e4121e). Report is 1 commits behind head on master.

Files Patch % Lines
app/port/schedule/TriggerHookWorker.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #702 +/- ## ========================================== - Coverage 96.81% 96.81% -0.01% ========================================== Files 181 181 Lines 18002 18003 +1 Branches 2337 2338 +1 ========================================== Hits 17429 17429 - Misses 573 574 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.