search

cnpryer / peef

A discord bot with uncompensated personality
MIT License
0 stars 0 forks source link

Basic `/stocks` #10

Closed cnpryer closed 3 years ago

cnpryer commented 3 years ago

/stocks symbol: [symbol]

Limited to 250 calls per user. Each dev should get have a distinct API Key (see #1 comments).

cnpryer commented 3 years ago

I gotta remember to update the readme or docs with these PRs. I need to add API_KEY usage documentation before we merge this.

cnpryer commented 3 years ago

I may add some needed variable cleaning to this pr as well

cnpryer commented 3 years ago

@ObiWanRohan I want to try adopting less strict PR merge requirements for at least us two. I feel like waiting for full review on certain PRs may be unnecessary if adjustments are made to keep us on the same page with direction for @peef.

For serious changes we can make it clear that full reviews are necessary before merging, but for this PR I believe were on the same page and if there are any additional changes either one of us want we can incorporate them in future refactors (I have a feeling I'll want to refactor a ton as I learn go).

I'd like to move on to #11 and #12.