cnr-ibba / IMAGE-InjectTool

Load IMAGE data into BioSample
https://inject.image2020genebank.eu
GNU General Public License v3.0
3 stars 0 forks source link

:sparkles: Error from USI API modeled as ValidationResult #94

Closed bunop closed 4 years ago

bunop commented 4 years ago

Description

With this PR errors returned by USI during submission into BioSamples are modeled like errors in validation, in order to easily map which sample has issues from BioSamples point of view. Errors are partially modelled like validation errors in database: Since is not possible to map an error to a particoular column, it isn't possible to start the batch update process from such error: batch updates are columns specific and for such reason error views don't have links to batch update pages

Related Issue

closes #13

Motivation and Context

This change will map BioSamples errors like validation error. This change will be useful when the option to filter out samples relying on their status will be provided

How Has This Been Tested?

Tests were performed with unittest and by submitting data to biosamples test environment during an issue in such environment

Types of changes

Checklist:

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.01%) to 97.945% when pulling e6eca643fa968cf95a6627bac862cf621dbd14e6 on issue-13 into ba9252e7b14fac85a635c5ea3d8d12044efe2b83 on devel.