cnr-isti-vclab / openlime

Web-based, advanced images viewer (RTI, multispectral, BRDF, etc. )
GNU General Public License v3.0
23 stars 6 forks source link

Limit light angle when viewing HSH basis #38

Closed EloiGattet closed 1 year ago

EloiGattet commented 1 year ago

As HSH isn't bounded at the extremities is gives weird colors the moment the light are the most raking.

Just before raking light :

Capture d’écran, le 2022-10-06 à 16 04 40

and just after, when the color get strange.

Capture d’écran, le 2022-10-06 à 16 04 30

It can be unsettling for new users and give them the feeling the RTI isn't right (except it is). Would it be possible for OpenLime to limit the max angle automatically to prevent when HSH basis is detected in the info.json?

ponchio commented 1 year ago

There already was a limit 0.1 (in radians) for the minimal angle in raking lights. I have added a parameter OpenLIME.HSH.minElevation that allows you to configure the minimum elevation. In radians, default is now 0.15 (up from 0.1 which was the previous default).