Implement state, timestamp and party

cnrad / lanyard-profile-readme

🏷️ Discord Presence in your GitHub Profile

https://lanyard.cnrad.dev

752 stars 101 forks source link

Implement state, timestamp and party #21

Closed leonardssh closed 3 years ago

leonardssh commented 3 years ago

This pull request implements the following:

activity state
activity timestamps (with toggle option hideTimestamp)
activity party size (if any)

What I've changed:

applied the filter method to take activities that have type === 0
added a new function to calculate the elapsed time for timestamp elapsedTime

Little formatting (unintentional, vscode is to blame) 😅

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cnrad/lanyard-profile-readme/2mzFcuZd12BD2UZAiHzmkywuLYmc
✅ Preview: https://lanyard-profile-readme-git-fork-leonardssh-feat-st-1bb23f-cnrad.vercel.app

cnrad commented 3 years ago

Looks good for the most part, a few things though:

If hideTimestamp is true, center the content again so it displays like it currently does (without this PR)
Fix elapsed time issue, as shown in the Discord

If anything else comes to mind or I notice something, I'll let you know.

cnrad commented 3 years ago

This looks pretty much good aside from one small change (sorry for being picky, haha) Is there a possibility that you could change the activity text content from margin-top: -3px to margin-top: -6px just so it's more centered with the thumbnail, like this?

As opposed to what it is currently, this:

Everything else looks good, so once you do this quick fix I'll merge :+1: