cnrad / lanyard-profile-readme

🏷️ Discord Presence in your GitHub Profile
https://lanyard.cnrad.dev
751 stars 101 forks source link

feat: Implement #55 #56

Closed GravityScriptsV2 closed 5 months ago

GravityScriptsV2 commented 5 months ago

Hello! I've implemented the feature mentioned in https://github.com/cnrad/lanyard-profile-readme/issues/55, by the way, I'm not sure if the SVG's height should stay or shrink when activity section is hidden.

vercel[bot] commented 5 months ago

@GravityScriptsV2 is attempting to deploy a commit to the Conrad's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lanyard-profile-readme ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 0:01am
cnrad commented 5 months ago

I think for a parameter such as this, it'd be better to straight up ignore the activity (treat it as if Spotify wasn't playing), rather than shrinking it - so if you could make that one change I'll approve, everything else lgtm