search

cnrl / CoNeX

Cortical Network for everything!
MIT License
3 stars 0 forks source link

Modify CorticalColumn for compatibility with new config modules #13

Closed realamirhe closed 1 year ago

realamirhe commented 1 year ago

Could you please provide your development branch so i can follow up and update the possibly needed changes

atenagm1375 commented 1 year ago

Could you please provide your development branch so i can follow up and update the possibly needed changes

Everything is on refactor branch. Saeed seems to have taken care of most. Review it and take actions as required.

realamirhe commented 1 year ago

LGMT

realamirhe commented 1 year ago

although the data_loader does not need to be stored in the class instance

atenagm1375 commented 1 year ago

although the data_loader does not need to be stored in the class instance

We will face some difficulties otherwise. Location and Sensory might share dataloader and dataset behavior, in which we are going to need extra access (the data in a single iteration should be identical for both populations, but it won't be since the behavior is called once per NeuronGroup). This is the result of a quite long discussion with @saeedark and we welcome other suggestions for solving the issue.

realamirhe commented 1 year ago

although the data_loader does not need to be stored in the class instance

We will face some difficulties otherwise. Location and Sensory might share dataloader and dataset behavior, in which we are going to need extra access (the data in a single iteration should be identical for both populations, but it won't be since the behavior is called once per NeuronGroup). This is the result of a quite long discussion with @saeedark and we welcome other suggestions for solving the issue.

I will follow up and thing about other possible scenarios, with him tonight. and follow appropriate action if needed. will notify you the changes for PR review