search

cnrv / fpga-rocket-chip

Wrapper for Rocket-Chip on FPGAs
Other
124 stars 26 forks source link

Submodule riscv-test-env URL is outdated. #21

Closed thomascp closed 2 years ago

thomascp commented 2 years ago 
// fpga-rocket-chip/rocket-chip/torture
$ git diff
diff --git a/.gitmodules b/.gitmodules
index 953c66b..a557616 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,3 @@
 [submodule "env"]
        path = env
-       url = git://github.com/ucb-bar/riscv-test-env.git
+       url = https://github.com/riscv/riscv-test-env.git
wsong83 commented 2 years ago

I think I would simply accept it if it is put into a PR.

thomascp commented 2 years ago

It is in the rocket-chip/torture/env, they already updated it here, so I guess we can only explain this in the README.md, and remind the user to change this submodule URL?

$ cd rocket-chip/torture/
$ git submodule set-url env https://github.com/riscv/riscv-test-env.git
wsong83 commented 2 years ago

We do not actually use torture. In this case, it might be easier for me just bump up the commit. Will do it in the following days. Thanks.

wsong83 commented 2 years ago

Fixed by PR #22