search

cnthompson / Beer366

It's a One-A-Day Leap Year Beer Celebration
6 stars 2 forks source link

Breadcrumb spacing #32

Open cnthompson opened 10 years ago

cnthompson commented 10 years ago

The current site uses spaces when displaying the breadcrumbs to make them more readable (in my opinion). It would be nice to buffer the breadcrumb sections with spaces as well as the divider in order to more easily tell what the individually clickable links are.

starryknight64 commented 10 years ago

Interesting... I could've sworn there used to be spaces around those. Regardless, this is any easy one to plink out.

starryknight64 commented 10 years ago

From @cnthompson:

Looks like you attempted to fix this for locations, but have introduced another error in the process. The final separating slash is at the end of the entire sequence, rather than separating the penultimate and final values. See attached image breadcrumb_spacing.png. Also, we at least use the breadcrumbs on the styles page, and that logic was not updated. Do we use it elsewhere? Finally, the locations map seems to just generally not be working. I don't know if this is related to this change or another change you've made recently. To get the picture I've attached, I went to a brewery page and clicked on its state.

breadcrumbs

starryknight64 commented 10 years ago

The spacing bug should be fixed and the divider spacing should now be what it was in the original site.