search

cnthompson / Beer366

It's a One-A-Day Leap Year Beer Celebration
6 stars 2 forks source link

External link display on beer page #34

Open cnthompson opened 10 years ago

cnthompson commented 10 years ago

On a beer's page, if there is no BA rating, an N/A is displayed, which is correct, but it is still made into an external hyperlink that goes to an invalid page.

starryknight64 commented 10 years ago

From @cnthompson:

This is getting closer, but now if we have a page but no ranking, it doesn't create the hyperlink. Basically, any time we have a page, there should be a link.

starryknight64 commented 10 years ago

This should now be fixed.

cnthompson commented 10 years ago

Not quite fixed. Now if a beer doesn't have a rating or beer advocate page, when you edit the beer the beer advocate space is populated with: http://beeradvocate.com/beer/profile/null

starryknight64 commented 10 years ago

Additionally, when you clear the BA URL field and submit a valid BA Rating, the rating doesn't show because the URL isn't valid.

starryknight64 commented 10 years ago

I believe this is now fixed.