search

cnthompson / Beer366

It's a One-A-Day Leap Year Beer Celebration
6 stars 2 forks source link

Availability of Delete when editing #35

Open cnthompson opened 10 years ago

cnthompson commented 10 years ago

On the Add/Edit Brewery & Beer pages, I'm pretty sure I don't like the idea of allowing a brewery to be deleted. If you delete a brewery, all the beers associated with the brewery would disappear, then all the drinks logged for those beers would be invalid. That's a lot of damage from a single button click. I think the only way a brewery should be deletable is if it doesn't have any beers associated with it. Similarly, the only way a beer should be deletable is if it doesn't have any drinks logged (or isn't in anyone's cellar).

starryknight64 commented 10 years ago

Good point. I currently do have that button available strictly to admins of Beer366, so there is that. I'll make that button smarter so it is only enabled if the conditions you have mentioned have been met. I'll even give it a tooltip explaining why it's disabled.