search

cnthompson / Beer366

It's a One-A-Day Leap Year Beer Celebration
6 stars 2 forks source link

Improvements of beer-ranking explanatory text #40

Open cnthompson opened 10 years ago

cnthompson commented 10 years ago

On the Log Drink page, I like the text next to the rating that appears for values from 0 to 5. However, since you're already detecting that, it seems to me that if there's a value < 0 or > 5, you should pop up sme text saying what the valid range is. Also, if you enter an invalid range, and then it goes back to the page with the error text, entering a valid range will concatenate your helpful text with the word error.

starryknight64 commented 10 years ago

I'll be pushing a change to the log drink page soon, let me know if this isn't solved after that.

starryknight64 commented 10 years ago

This commit added a few improvements to the log drink page: https://github.com/starryknight64/Beer366/commit/573fa2206ad91f3fd614bd942bfba0ec46027500

starryknight64 commented 10 years ago

From @cnthompson:

The new text is nice, I'm still seeing the concatenation issue on Firefox