deletion: delete spec/workload/scalability_spec.cr

cnti-testcatalog / testsuite

📞📱☎️📡🌐 Cloud Native Telecom Initiative (CNTI) Test Catalog is a tool to check for and provide feedback on the use of K8s + cloud native best practices in networking applications and platforms

https://wiki.lfnetworking.org/display/LN/Test+Catalog

Apache License 2.0

169 stars 70 forks source link

deletion: delete spec/workload/scalability_spec.cr #1969

Closed barmull closed 2 months ago

barmull commented 2 months ago

Description

Deleted scalability.cr as test group does not exist anymore.

Issues:

Refs: #1960

How has this been tested:

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Verified all A/C passes
- [ ] develop
- [ ] master
- [ ] tag/other branch
[ ] Test environment
- [ ] Shared Packet K8s cluster
- [ ] New Packet K8s cluster
- [ ] Kind cluster
[ ] Have not tested

Types of changes:

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] No updates required.

Code Review

[ ] Does the test handle fatal exceptions, ie. rescue block

Issue

[ ] Tasks in issue are checked off

barmull commented 2 months ago

It might break github actions, because scalability test was being skipped. Is it checked?

agentpoyo commented 2 months ago

It might break github actions, because scalability test was being skipped. Is it checked?

There are no actual tests tagged with scalability. I believe this was changed to another category after the categories were revamped for the certification to simplify the tests categories.

agentpoyo commented 2 months ago

When I run:

$ ./cnf-testsuite scalability
Task scalability was not found

There are no tests or tasks assigned to scalability. We should merge the fix in case we tag future tests as scalability or remove entirely. @taylor @wavell @denverwilliams @HashNuke

taylor commented 2 months ago

@wavell remove or merge?

kosstennbl commented 2 months ago

IMO, scalability_spec.cr should be deleted completely (as test group doesn't exist anymore).

The test is supposed to test increase_decrease_capacity cnf-test from compatibility category. In compatibility_spec.cr, this spec test is absent, but it is present in configuration_spec.cr (seemingly - misplaced there).

Proposed steps:

In this pull request - delete scalability_spec.cr completely.
Create new issue to move spec for increase_decrease_capacity from configuration_spec.cr to compatibility_spec.cr