cnti-testcatalog / testsuite

📞📱☎️📡🌐 Cloud Native Telecom Initiative (CNTI) Test Catalog is a tool to check for and provide feedback on the use of K8s + cloud native best practices in networking applications and platforms
https://wiki.lfnetworking.org/display/LN/Test+Catalog
Apache License 2.0
173 stars 71 forks source link

Remove -ti in docker and kubectl calls #1984

Closed collivier closed 5 months ago

collivier commented 5 months ago

Description

It avoids passing stdin to the container when useless. Please note it removes a couple of issues highlighted by [1] in airgap specs.

It also removes all useless blank chars in the files modified by this change.

[1] https://github.com/cnti-testcatalog/testsuite/pull/1949

How has this been tested:

Types of changes:

collivier commented 5 months ago

@HashNuke would you mind running the specs in your branch. I ran a few specs locally but this change requires a full verification. Thank you in advance.

HashNuke commented 5 months ago

Build passing - https://github.com/cnti-testcatalog/testsuite/actions/runs/8769450532

HashNuke commented 5 months ago

Resolved conflict by commenting out airgap specs as in main branch.