cnti-testcatalog / testsuite

📞📱☎️📡🌐 Cloud Native Telecom Initiative (CNTI) Test Catalog is a tool to check for and provide feedback on the use of K8s + cloud native best practices in networking applications and platforms
https://wiki.lfnetworking.org/display/LN/Test+Catalog
Apache License 2.0
173 stars 71 forks source link

Fix: Routed logs test now correctly checks if CNF is being tailed #2034

Closed svteb closed 3 months ago

svteb commented 4 months ago

Description

Fixed two issues regarding routed_logs and fluent family of functions as described in referenced issues. Nearly everything was refactored, but all the install/uninstall and tailing functions have been manually tested and the spec tests are passing as well. Main reasons for the refactor were shortening the code and removing duplicates.

As for the refactors, the CONFIG variable does not look all that pretty but I could not figure out a better way to achieve the modularity.

Issues:

Refs: #2025 #2016

How has this been tested:

Types of changes:

Checklist:

Documentation

Code Review

Issue

taylor commented 4 months ago

re-running specs after runners restored

horecoli commented 3 months ago

LGTM, good job 👍

martin-mat commented 3 months ago

gh actions passed https://github.com/cnti-testcatalog/testsuite/actions/runs/9439225077