Allow GH actions on PRs from forked repos

[martin-mat]

Make "docker login" in spec execution optional. Note that it has anyway limited (if any) effect as docker registry mirror cache is used and docker login does not really have expected affect. The registry mirror cache itself needs to be configured with respective credentials.

Issues:

Refs: #2066

How has this been tested:

• [ ] Covered by existing integration testing
• [ ] Added integration testing to cover
• [ ] Verified all A/C passes
  • [ ] develop
  • [ ] master
  • [ ] tag/other branch
• [ ] Test environment
  • [ ] Shared Packet K8s cluster
  • [ ] New Packet K8s cluster
  • [ ] Kind cluster
• [ ] Have not tested

Types of changes:

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation update

Checklist:

Documentation

• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] No updates required.

Code Review

• [ ] Does the test handle fatal exceptions, ie. rescue block

Issue

• [ ] Tasks in issue are checked off

[horecoli]

What about registry_spec.cr where docker login is mandatory? There is code like:

if ENV["DOCKERHUB_USERNAME"]? && ENV["DOCKERHUB_PASSWORD"]? result = Dockerd.exec("docker login -u $DOCKERHUB_USERNAME -p $DOCKERHUB_PASSWORD", force_output: true) Log.info { "Docker Login output: #{result[:output]}" } else puts "DOCKERHUB_USERNAME & DOCKERHUB_PASSWORD Must be set.".colorize(:red) exit 1 end

[martin-mat]

What about registry_spec.cr where docker login is mandatory? There is code like:

if ENV["DOCKERHUB_USERNAME"]? && ENV["DOCKERHUB_PASSWORD"]? result = Dockerd.exec("docker login -u $DOCKERHUB_USERNAME -p $DOCKERHUB_PASSWORD", force_output: true) Log.info { "Docker Login output: #{result[:output]}" } else puts "DOCKERHUB_USERNAME & DOCKERHUB_PASSWORD Must be set.".colorize(:red) exit 1 end

Good point. Currently it passes because DOCKERHUB_USERNAME are set (but empty string) so the condition is true. Docker login fails but is ignored. At the end the test passes, despite not being logged in to dockerhub.