cnti-testcatalog / testsuite

📞📱☎️📡🌐 Cloud Native Telecom Initiative (CNTI) Test Catalog is a tool to check for and provide feedback on the use of K8s + cloud native best practices in networking applications and platforms
https://wiki.lfnetworking.org/display/LN/Test+Catalog
Apache License 2.0
169 stars 70 forks source link

[Improvement] Refactor K8sTshark module #2087

Open svteb opened 4 days ago

svteb commented 4 days ago

Is your feature request related to a problem? Please describe. The module currently holds 3 distinct functions, each having a duplicate with 1~ line changed. These duplicates should be revised.

Describe the solution you'd like Create more sensible interfaces. Shorten the code and remove the duplicates. Currently the problem with the module is dependency on uncertain wait times (120 seconds for tshark capture). A function that would terminate tshark capture after its begun would be very helpful.

Additional context The module is currently used only by suci and oran tests, thus not much code will need to be rewritten outside the module.