cnf_setup: Exit on setup failure or timeout

cnti-testcatalog / testsuite

📞📱☎️📡🌐 Cloud Native Telecom Initiative (CNTI) Test Catalog is a tool to check for and provide feedback on the use of K8s + cloud native best practices in networking applications and platforms

https://wiki.lfnetworking.org/display/LN/Test+Catalog

Apache License 2.0

174 stars 72 forks source link

cnf_setup: Exit on setup failure or timeout #2114

Closed kosstennbl closed 3 months ago

kosstennbl commented 3 months ago

Description

Fix handling unsuccessful cnf setup, if resources are not ready after timeout - then setup should fail with exit 1. Change specs accordingly, replace wait_count=0 with new option "ignore_setup_timeout". Add cnf_setup function to ShellCmd and use it for installation of CNFs during specs.

Issues:

Refs: #1937 #2083

martin-mat commented 3 months ago

It looks that this change did its job and revealed issues with cnf setup in spec tests. They need to be addressed though.

kosstennbl commented 3 months ago

Issues with "envoy" chart are brought by #2116, they should be resolved for CI to pass.

martin-mat commented 3 months ago

the change looks fine for me now, I will approve after the envoy issue is addressed.

martin-mat commented 3 months ago

rebase pls