fix: Change Helm library to CNFInstall module - Githubissues

cnti-testcatalog / testsuite

📞📱☎️📡🌐 Cloud Native Telecom Initiative (CNTI) Test Catalog is a tool to check for and provide feedback on the use of K8s + cloud native best practices in networking applications and platforms

https://wiki.lfnetworking.org/display/LN/Test+Catalog

Apache License 2.0

174 stars 72 forks source link

fix: Change Helm library to CNFInstall module #2127

Closed barmull closed 2 months ago

barmull commented 3 months ago

Description

affect CNFs that installing method is HelmDirectory
CNFs are correctly install into cnf-default namespace (if helm_install_namespace variable is not set)
change Helm::InstallMethod::HelmDirectory to CNFInstall::InstallMethod::HelmDirectory

Issues:

Refs: #2039

How has this been tested:

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Verified all A/C passes
- [ ] develop
- [ ] master
- [ ] tag/other branch
[ ] Test environment
- [ ] Shared Packet K8s cluster
- [ ] New Packet K8s cluster
- [X] Kind cluster
[ ] Have not tested

Types of changes:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] No updates required.

Code Review

[ ] Does the test handle fatal exceptions, ie. rescue block

Issue

[ ] Tasks in issue are checked off

martin-mat commented 3 months ago

needs rebasing

martin-mat commented 3 months ago

oran spec tests pass, but they don't work correctly. In fact they should fail, because waiting for CNFs to be deployed does not finish:

martin-mat commented 2 months ago

lgtm also now after fixing all issues. Great that all that those tests dependent on default namespaces were identified and fixed.