cntools / cnping

Minimal Graphical Ping Tool
Other
235 stars 35 forks source link

Windows: Old "with admin priviledges" version is broken #112

Open dreua opened 5 months ago

dreua commented 5 months ago

[...]

Even tho the version with admin privileges is broken i believe this PR is "completed" as on the current master this doesn't even compile. So i consider that feature "not made worse" :smile:

Originally posted by @mrbesen in https://github.com/cntools/cnping/issues/109#issuecomment-2102691518

I just wanted to have this documented, there is probably no real use in the "with admin prives" version anymore. Maybe we could consider removing the code and making the no admin version the only available.

mrbesen commented 5 months ago

Before we do remove that code, did someone other than me checked if it works? I have only tested it on one single machine, that might have some other (Group Policy) reasons for this to not work. Like i said, my windows debugging skills are limited.

But anyways: I am in favor of removing that code, as that is quite a lot of code, that is

cnlohr commented 5 months ago

Is there a recommended avenue forward, @dreua ?