Use full URL for iconfont

cntrump / hugo-notepadium

a fast gohugo theme, 100% JavaScript-free.

https://examplesite.lvv.me/

MIT License

332 stars 125 forks source link

Use full URL for iconfont #88

Closed reitzig closed 4 years ago

reitzig commented 4 years ago

Use baseURL explicitly to circumvent absolute paths failing if the site lives in a subfolder.

As an alternative, ../assets/... would work but relies on where exactly the CSS ends up being deployed; also, @cntrump rejected relative asset paths earlier.

cntrump commented 4 years ago

try the latest code please. using relative url.

reitzig commented 4 years ago

That seems to work, cool! :+1:

FWIW, you can do without the local $url variable:

url('{{- "/assets/font/iconfont.ttf" | relURL -}}')

reitzig commented 4 years ago

Friendly meta feedback, FYI: Contributing feels nicer if we collaborate on a PR that then gets merged, instead of you pushing to master and me closing the PR. :) I know it's a few more buttons to push on your end (been there), but I think creating a contribution-friendly atmosphere is worth it. If that's what you're after, of course.

cntrump commented 4 years ago

Thanks very much for your suggestions!