cnu1812 / Community-Library

This community-library is built for all community members, to have a one place for all available resources at one place.
https://community-library.netlify.app/
8 stars 8 forks source link

Hide gtag #33

Open cnu1812 opened 1 year ago

cnu1812 commented 1 year ago

Description

Hide gtag that is in docusaurus.config.js file in env file

Additional information

No response

Dun-sin commented 1 year ago

Do you mean remove this line? If so, can I work on it? https://github.com/cnu1812/Community-Library/blob/7d728377f572b3d176d5725c3b19ac635c478bdf/docusaurus.config.js#L176-L179

cnu1812 commented 1 year ago

Do you mean remove this line? If so, can I work on it?

https://github.com/cnu1812/Community-Library/blob/7d728377f572b3d176d5725c3b19ac635c478bdf/docusaurus.config.js#L176-L179

Not removing, generally this kind of keys are to be hidden, so to do this we have to create .env file and store there. You can take up this challenge and learn about env file if you want to

Dun-sin commented 1 year ago

Do you mean remove this line? If so, can I work on it? https://github.com/cnu1812/Community-Library/blob/7d728377f572b3d176d5725c3b19ac635c478bdf/docusaurus.config.js#L176-L179

Not removing, generally this kind of keys are to be hidden, so to do this we have to create .env file and store there. You can take up this challenge and learn about env file if you want to

I know about those, if it's to be hidden then creating a public env isn't the best thing, since every contributor will need it

cnu1812 commented 1 year ago

Ig env file is good to go cause gtag is normal, it's not that much secret.

Dun-sin commented 1 year ago

Ig env file is good to go cause gtag is normal, it's not that much secret.

Then why not leave it as it is, because by default, envs should not be seen in a repo except is a demo version

cnu1812 commented 1 year ago

Haha, it's not a problem. Why don't you look into other issues?

Dun-sin commented 1 year ago

Sure

cnu1812 commented 1 year ago

If you want raise your own issues and work on that!