search

cnuernber / dtype-next

A Clojure library designed to aid in the implementation of high performance algorithms and systems.
Other
328 stars 20 forks source link

Add JDK 19 FFI #73

Closed alexandergunnarson closed 1 year ago

alexandergunnarson commented 1 year ago

JDK 19 brings the Foreign Function Interface out of incubator and into preview. This change allows this lib to support JDK 19.

Note that I made the least change here. We could conditionalize mmodel to abstract/compress, or rename namespaces (e.g. mmodel → mmodel-jdk-pre-19, mmodel-jdk19 → mmodel).

cnuernber commented 1 year ago

I heartily approve. Thank you very much for taking the time to figure this stuff out - hopefully they do not change a lot from preview forward.

cnuernber commented 1 year ago

Next steps I guess will be to setup some scripts to install jdk-19 from command line and update the unit testing system. One thing that has really bothered me about the jdk ffi system is its inability to find system shared libraries - it really depends on your java-library-path variable matching your system ld.so path configuration and even then I have had issues. Maybe it is time to really dig through those issues and file real issues with the JDK.