cnuernber / dtype-next

A Clojure library designed to aid in the implementation of high performance algorithms and systems.
Other
319 stars 18 forks source link

Use :estimation-type option in percentiles #77

Closed frankleenaars closed 1 year ago

frankleenaars commented 1 year ago

The :estimation-type option passed to the percentiles function was not used. This happened because Percentile's withEstimationType method was called to change the EstimationType of the existing Percentile object, but this method returns a new Percentile object with the specified EstimationType instead.

Related docs: Percentile.withEstimationType

cnuernber commented 1 year ago

That is great - thanks it looks good to me.