search

cnuernber / dtype-next

A Clojure library designed to aid in the implementation of high performance algorithms and systems.
Other
319 stars 18 forks source link

Small typo in docstring #89

Closed phronmophobic closed 10 months ago

phronmophobic commented 10 months ago

https://github.com/cnuernber/dtype-next/blob/2fc364569634c37f99d399a7f58c99a7a9c0cae2/src/tech/v3/datatype/ffi.clj#L72

I think "syste" should be "system"?

I saw that pass-by-value structs got merged in and was curious what the implementation looked like. Looks great!

cnuernber commented 10 months ago

Thanks - I realized after the fact that this is pass-by-value in defining the library itself but not when defining a callback (define-foreign-interface). We will also need that soon-ish so that will be coming if I can get it done with JNA.

Also dtype structs now have accelerated get,put and reduce pathways :-)