search

cnumr / EcoIndex

Dépôt du site www.ecoindex.fr
http://www.ecoindex.fr
Other
67 stars 13 forks source link

fix: multilingual redirect on URL testing from the result page #304

Closed bgatellier closed 9 months ago

bgatellier commented 9 months ago

Closes #297 #300

vvatelot commented 9 months ago

Great this fixes the bug :slightly_smiling_face: I discovered a strange behaviour here: the url used by the initButtonRemakeAnalysis comes from the ResultCacheService.getLast().url... So if I understand it will relaunch an analyzis with the latest url you analyzed, but let's imagine that you directly comes to the result page without having analyzed any page... It will not work ?

Anyway, this is another discussion, this PR can be merged :clap:

bgatellier commented 9 months ago

Great this fixes the bug 🙂 I discovered a strange behaviour here: the url used by the initButtonRemakeAnalysis comes from the ResultCacheService.getLast().url... So if I understand it will relaunch an analyzis with the latest url you analyzed, but let's imagine that you directly comes to the result page without having analyzed any page... It will not work ?

Anyway, this is another discussion, this PR can be merged 👏

Good point. As far as I understand after a quick look at the code, this method looks into the localstorage of the browser. So it seems that it can fails. If you have already tested it, you can open an issue :wink:

I'm merging this issue