cnumr / EcoIndex

Dépôt du site www.ecoindex.fr
http://www.ecoindex.fr
Other
65 stars 13 forks source link

Fix: badge paragraph on the result page #318

Closed bgatellier closed 5 months ago

bgatellier commented 5 months ago

Changelog

Screenshots

Before / after (FR)

Before After
image image
image image

Before / after (EN)

Before After
image image
image image

Closes #292

bgatellier commented 5 months ago

💭 thought(non-blocking): I don't know if the formulation is good: "Download the badge"... I mean when clicking on the link, the user will not directly download the badge.

I would have said something like "If you want to display the ecoindex badge on your website, go to the project page" What do you think? (what make me think that we should also translate ecoindex badge project to english...)

Agree about the non-meaningful text. But I'll go with a more price text like:

Show your score on the webpage by adding the ecoIndex badge. See how to do it on the project page.

However, if we want more engagement from the user, we should display the badge directly on the page with the code the user have to copy to integrate it on the page. This way, the user will figure what the badge is about (showing the score) and how it looks like. That could be a new improvement issue 😉

vvatelot commented 5 months ago

Yes! I like the idea! To me, this PR is OK, and we can open a new improvement one!