cnumr / ecoindex_python_fullstack

Refactoring of ecoindex in one monorepo using polylith pattern
Other
13 stars 3 forks source link

[Bug]: Sitemap only found 1 URL in Ecoindex-cli #62

Open guillaumew opened 6 months ago

guillaumew commented 6 months ago

What happened?

Step to reproduce : alias ecoindex-cli="docker run -it --rm --add-host=host.docker.internal:host-gateway -v /tmp/ecoindex-cli:/tmp/ecoindex-cli vvatelot/ecoindex-cli:2.26.0 ecoindex-cli" ecoindex-cli analyze --url https://simbios.fr --sitemap https://simbios.fr/sitemap.xml --export-format json

Only 1 URL was found while the sitemap contains more than 50 elements : https://simbios.fr/sitemap.xml

Project

Ecoindex CLI

What OS do you use?

Linux

urls

https://simbios.fr/sitemap.xml

Relevant log output

No response

Code of Conduct

vvatelot commented 6 months ago

@PaulPHPE maybe you can have a look at this one ?

PaulPHPE commented 6 months ago

Hello @vvatelot @guillaumew ! If you provide a url and a sitemap the cli only takes into account the url argument. You should start the analysis as follow : ecoindex-cli analyze --sitemap https://simbios.fr/sitemap.xml --export-format json

I realize that the README should mention it. Moreover, we shouldn't ask a confirmation for sitemap scraping when we have both url and sitemap. I will make the modifications !

guillaumew commented 6 months ago

Thanks @PaulPHPE. I didn't even realized I had this url argument. Sorry about that.

github-actions[bot] commented 4 months ago

This issue has been marked as inactive because it hasn't been updated for 30 days. If it's not updated within 7 days, it will be automatically closed. To prevent it from being closed, you can add the keep open label.