search

cnwangjie / better-onetab

:bookmark_tabs: A better OneTab for Chrome :memo: Temporarily removed from firefox :construction: V2 is WIP
https://chrome.google.com/webstore/detail/better-onetab/eookhngofldnbnidjlbkeecljkfpmfpg
MIT License
1.68k stars 286 forks source link

Storing tabs into a pinned titled list results in duplicate tabs #97

Open nkgm opened 5 years ago

nkgm commented 5 years ago

I see where this is coming from, but imagine the scenario where you want to open all tabs of a titled list (in new window), do some work, maybe open or close a few tabs, and then save your progress back to that same titled list. Right now, "store into a titled list" will cause any existing tabs to be duplicated.

To keep it flexible, maybe add an "overwrite titled list" option?

EDIT: I have found the "Remove duplicate item in a list" setting, but we still need the "overwrite titled list" option when tabs have been removed.

cnwangjie commented 5 years ago

Hi, thank you for your suggestion. I think you want to store the tabs into a titled list and remove the tabs existed in that list before, so that you could keep the workspace in a specific titled list. I think it will be very useful. I will add this features in the new version.

What do you think about add a "store as a titled list" button in context menus? But it is a limit for the top level context menus and too many levels menus cause trouble in use.

If you have any further ideas it is very welcome to share with us.

nkgm commented 5 years ago

"Store as a titled list" sounds very useful even though I'm not sure how it would work. Would it let you choose an existing (pinned?) list? Would it let you create a new one on the fly?

Also, "Store as a titled list" looks too similar to "Store into a titled list" (too easy to click the wrong one). Maybe rename them to "Save as titled list" and "Add to titled list"?

~On a separate note, I don't think you need all the options to "store all", "store selected", "store to the left" etc. When tabs are selected, the top level menu item becomes "Add selected (14) to titled list", and when no selected tabs, "Add all (56) to titled list". And similarly "Save selected (14) titled list", "Save all (56) as titled list". This way, you only have 2 menu levels: "Save selected (14) to titled list" -> "My research xyz".~ (EDIT: but what happens if you only want to Save/Add just 1 tab? Does it save all or just this 1 tab selection? I'll experiment with a fork, see how it works in practice).

Pictor13 commented 5 years ago

What about "Update titled list with current window", or "Replace titled list with current window" ?

Anyway, yes, I came here also because the "Remove duplicate item in a list" doesn't seem to work. (I didn't give a look to the code yet, sorry)