search

cnzzx / GeMap

[ECCV'24] Online Vectorized HD Map Construction using Geometry
https://invictus717.github.io/GeMap/
Apache License 2.0
158 stars 12 forks source link

Attention mask definition. #1

Closed Chuck-Yu closed 6 months ago

Chuck-Yu commented 6 months ago

Hi, thanks for your great work.

After reading your paper and code, I feel confuse about the attn_mask definition. According to MultiheadAttention.attn_mask, 'For a binary mask, a True value indicates that the corresponding position is not allowed to attend.'

https://github.com/cnzzx/GeMap/blob/b2b085e1584ca767c9d384e51b96f209babb7234/projects/mmdet3d_plugin/gemap/modules/geometry_decoupled_attention.py#L74-L78

cnzzx commented 6 months ago

Thanks for your issue. You're right.

There might be some mistakes when cleaning up the code. We've now fixed it up and you can view it in this commit.