Prep for first "release"

co-analysis / govukhugo-r

An R package for working with govuk-hugo

https://co-analysis.github.io/govuk-hugo-demo/

Other

5 stars 1 forks source link

Prep for first "release" #1

Open mattkerlogue opened 2 years ago

mattkerlogue commented 2 years ago

As discussed in the govuk-hugo repo govukhugo is probably ready for a properly release and better versioning. The R package should probably also follow suit.

Things to consider:

[ ] Does the package need unit tests/examples in documentation (probably)
[ ] Investigate/fix plotly/crosstalk interaction issues
[ ] Hex sticker

mattkerlogue commented 2 years ago

On further investigation, Plotly interaction issue seems to have gone away.

mattkerlogue commented 2 years ago

Fixed issue with Plotly responsiveness in d37b577.

TLDR: although {plotly} docs claim responsive, the containing div is given a default size which fixes the size of the plot. Fix is a hack to remove the style argument from containing div which results in chart becoming responsive.

Users should probably still set width/height of their chart to give plotly the necessary aspect ratio in the underlying SVG object.