search

co-cddo / ukgov-metadata-exchange-model

A metadata model for describing data assets for exchanging between UK government organisations.
https://co-cddo.github.io/ukgov-metadata-exchange-model/
Other
12 stars 1 forks source link

URIs on enumeration pages are incorrect #61

Closed AlasdairGray closed 8 months ago

AlasdairGray commented 8 months ago

I see, that's OK. Then let me explain what happened in my case: there is a link for non existent page. I open this page: https://co-cddo.github.io/ukgov-metadata-exchange-model/OrganisationValues/ then click the URI: link and end with this page (404): https://co-cddo.github.io/ukgov-metadata-exchange-model/OrganisationValues/OrganisationValues

Originally posted by @soydaner in https://github.com/co-cddo/ukgov-metadata-exchange-model/issues/59#issuecomment-1785499098

Screenshot 2023-10-30 at 16 13 04 Screenshot 2023-10-30 at 16 13 08

AlasdairGray commented 8 months ago

This has come about when we changed the base URI of the model (20b238ed2000d63fd3f9daf5fa8c259a22c63616).

AlasdairGray commented 8 months ago

The same behaviour is present on the LinkML documentation site, e.g. https://linkml.io/linkml-model/1.6.x/docs/PvFormulaOptions/.

The problem stems from the way that the framework generates a link for the enumeration. It does not take into account the enum_uri value. Reported an issue to LinkML https://github.com/linkml/linkml/issues/1682.

AlasdairGray commented 8 months ago

I would expect that this will be fixed by LinkML team and no changes are needed locally.

AlasdairGray commented 8 months ago

This has been identified as an error in the template file which means that we need to update our copy of the template to incorporate the fix, see https://github.com/GenomicsStandardsConsortium/mixs/pull/688/commits/24ab04a017f2b5292cc7d204ad2467ffca95697d