search

coachcare / npm-datepicker

Material Datepicker Fork with TimePicker by CoachCare
MIT License
32 stars 18 forks source link

Failing production build with fullTemplateTypeCheck & strictNullChecks #13

Closed Enngage closed 6 years ago

Enngage commented 6 years ago

Hi, another one :-)

Production build with with ts.config option:

"strictNullChecks": true

and Angular specific:

 "angularCompilerOptions": {
    "fullTemplateTypeCheck": true,
  },

Fails with: ERROR in node_modules\@coachcare\datepicker\coachcare-datepicker.d.ts.MatYearsView.html(3,3): : Object is possibly 'null'.

b2

Enngage commented 6 years ago

Any chance you can fix this?

matheo commented 6 years ago

@Enngage I will look into this as soon as I can, been busy in my job ;)

matheo commented 6 years ago

@Enngage please try 0.9.6 and report back if there's a behavior change with the strict null changes ;)

Enngage commented 6 years ago

Awesome, thanks :) I just went on Vacation so I won't be able to check right now, but will as soon as I can.

On Mon, 23 Jul 2018 at 18:42, Mateo Tibaquirá notifications@github.com wrote:

@Enngage https://github.com/Enngage please try 0.9.6 and report back if there's a behavior change with the strict null changes ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/selvera/npm-datepicker/issues/13#issuecomment-407122920, or mute the thread https://github.com/notifications/unsubscribe-auth/AGzoR2BWZfWVcPjax4kgWUi1-9WytIu8ks5uJfzegaJpZM4VAoIk .

matheo commented 6 years ago

@Enngage this should be completely fixed on @coachcare/datepicker 0.9.9