coachcare / npm-datepicker

Material Datepicker Fork with TimePicker by CoachCare
MIT License
32 stars 18 forks source link

Animation Error #18

Closed psenechal closed 6 years ago

psenechal commented 6 years ago

Hello,

I'm getting the following error after updating to the latest release (0.9.6).

Unable to process animations due to the following failed trigger transitions @transformPanel has failed due to: - `query("@fadeInCalendar")` returned zero elements. (Use `query("@fadeInCalendar", { optional: true })` if you wish to allow this.)

Any ideas if this is something I can handle through configuration? Thanks.

gltorres commented 6 years ago

I am having the same problem.

cverons commented 6 years ago

Hi,

Maybe this is due to @angular/material issue #12199

I'm providing an example on stackblitz hoping that could help solving this exception quickly.

Please @matheo can you just confirm if compling using ng build --prod --build-optimizer can solve this issue ?

Sincerly

matheo commented 6 years ago

@xalhera yes, that's the issue.

I'm using Nx 6.1.1 with Angular* 6.1.0 and Angular Material 6.4.1 and I cannot reproduce the issue disabling/enabling buildOptimizer, maybe the latest version already fixed the issue?

I recently ng updateed all my project to Angular CLI 6.1.1 and it works tho.

matheo commented 6 years ago

@psenechal @gltorres If the latest versions of Angular, CLI and Material doesn't work for you guys, I can release a new version without that animation.

gltorres commented 6 years ago

I decided not to use it for my last release, but I'll try updating angular and trying it out to make sure it works. I was using angular 6.0.9, and material 6.4.1.

I will let you know by the end of the day if it works :)

Thank you!

matheo commented 6 years ago

Ok, I've removed the animation from the calendar component and fixed some strict null checks. Sadly stackblitz didn't detect the latest 0.9.9 release and couldn't verify that it's ok now, but I bet it is :)

cverons commented 6 years ago

I confirm that the issue is gone with the 0.9.9 release.

Thanks a lot @matheo for your quick update and your great job :)

matheo commented 6 years ago

@xalhera Great :D